Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProConnect - Message d'avertissement précisant que ProConnect n'est p… #1123

Merged
merged 3 commits into from
Jan 9, 2025
Merged

ProConnect - Message d'avertissement précisant que ProConnect n'est p… #1123

merged 3 commits into from
Jan 9, 2025

Conversation

NicolasBuquet
Copy link
Contributor

@NicolasBuquet NicolasBuquet commented Nov 18, 2024 •
edited
Loading

Fix #1100

Simulator Screenshot - iPhone 16 - 2025-01-08 at 15 52 36

@NicolasBuquet
ProConnect - Message d'avertissement précisant que ProConnect n'est p…
40fb229 
…as disponible sur toutes les instances actuellement.
@NicolasBuquet NicolasBuquet linked an issue Nov 18, 2024 that may be closed by this pull request
PC - login alors que le serveur Synapse n'est pas configuré ProConnect #1115 #1100
Closed
yostyle
yostyle approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btchap/Config/BuildSettings.swift
@@ -124,6 +124,7 @@ final class BuildSettings: NSObject {
static let applicationServicesStatusUrlString = "https://status.tchap.numerique.gouv.fr/"
static let applicationAcceptableUsePolicyUrlString = ""
static let proConnectInfoUrlString = "https://proconnect.gouv.fr/"
static let proConnectAvailabilityFaqArticleUrlString = "https://aide.tchap.beta.gouv.fr/fr/article/se-connecter-a-tchap-avec-proconnect-1dh1peg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add the host part in a const.

yostyle
yostyle approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasBuquet NicolasBuquet merged commit 4ee36a4 into develop Jan 9, 2025
2 of 5 checks passed
@NicolasBuquet NicolasBuquet deleted the 1100-pc-login-alors-que-le-serveur-synapse-nest-pas-configure-proconnect-1115 branch January 9, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

@odelcroi odelcroi Awaiting requested review from odelcroi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PC - login alors que le serveur Synapse n'est pas configuré ProConnect #1115
2 participants
@NicolasBuquet @yostyle